Skip to content
Snippets Groups Projects

Add communicator interface

All threads resolved!

In merge !227 (merged) a test was added to ParameterTest which needs an instant of the class Communicator. Using the concrete class poses two problems, as the communicator depends on CUDA.

  1. ParamterTest needs CUDA to compile, even though it is not necessary for the tests themselves
  2. The new test from !227 (merged) fails in the pipeline (e.g. https://git.rz.tu-bs.de/irmb/VirtualFluids_dev/-/jobs/137967)

Adding an interface for the communicator fixes both problems. The new interface is named Communicator, while the concrete class was renamed to MpiCommunicator

Note: As mentioned by Sören, the communicator should be reworked and use the existing code in src/mpi (https://git.rz.tu-bs.de/irmb/VirtualFluids_dev/-/issues/45)

Edited by Anna Wellmann

Merge request reports

Approved by

Merged by Anna WellmannAnna Wellmann 1 year ago (Apr 28, 2023 9:01am UTC)

Merge details

  • Changes merged into develop with 14f5cf45.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sören Peters
  • Anna Wellmann added 2 commits

    added 2 commits

    • 943ebdb1 - Remove timer from Communicator
    • 712f30c2 - Rmove unused gatherNups function and rename sumNups

    Compare with previous version

  • Anna Wellmann resolved all threads

    resolved all threads

  • Anna Wellmann added 1 commit

    added 1 commit

    Compare with previous version

  • Anna Wellmann changed the description

    changed the description

  • Sören Peters approved this merge request

    approved this merge request

  • Anna Wellmann mentioned in commit 14f5cf45

    mentioned in commit 14f5cf45

  • merged

  • Anna Wellmann mentioned in merge request !236 (merged)

    mentioned in merge request !236 (merged)

  • Please register or sign in to reply
    Loading