Add communicator interface
Merged
Add communicator interface
All threads resolved!
All threads resolved!
In merge !227 (merged) a test was added to ParameterTest which needs an instant of the class Communicator. Using the concrete class poses two problems, as the communicator depends on CUDA.
- ParamterTest needs CUDA to compile, even though it is not necessary for the tests themselves
- The new test from !227 (merged) fails in the pipeline (e.g. https://git.rz.tu-bs.de/irmb/VirtualFluids_dev/-/jobs/137967)
Adding an interface for the communicator fixes both problems.
The new interface is named Communicator
, while the concrete class was renamed to MpiCommunicator
Note: As mentioned by Sören, the communicator should be reworked and use the existing code in src/mpi (https://git.rz.tu-bs.de/irmb/VirtualFluids_dev/-/issues/45)
Edited by Anna Wellmann
Merge request reports
Activity
Filter activity
As you are working on the communicator, you could have a look on this #45 (closed)
added 2 commits
requested review from @soe.peters
- Resolved by Anna Wellmann
- Resolved by Anna Wellmann
- Resolved by Anna Wellmann
- Resolved by Anna Wellmann
mentioned in commit 14f5cf45
mentioned in merge request !236 (merged)
Please register or sign in to reply