Skip to content
Snippets Groups Projects

Add recommendations for viscosity and velocity for K17 kernel and move the check to kernel

Merged Add recommendations for viscosity and velocity for K17 kernel and move the check to kernel
m.schoenherr/VirtualFluids_dev:refactor/kernel-parameter-check into develop
Merged Anna Wellmann requested to merge m.schoenherr/VirtualFluids_dev:refactor/kernel-parameter-check into develop

The viscosity and velocity for which we can use a collision kernel are specific to the kernel variant. Therefore, the checks should be executed by the Kernel class and not by Parameter.

Additional changes:

  • in unit tests: remove cout capture with testing::internal. testing::internal is a private API of GoogleTest and therefore should not be used like for non-internal purposes like as was here. Another reason for the removal is that for the unit tests added in this merge, capturing cout with testing::internal did not work with msvc.
  • update spdlog
  • rename namespace testingVF to testing::vf
Edited by Anna Wellmann

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Martin SchönherrMartin Schönherr 7 months ago (Aug 6, 2024 8:09am UTC)

Merge details

  • Changes merged into with b69720b5.
  • Deleted the source branch.

Pipeline #43719 passed

Stage: build
    Stage: test
      Stage: analyze
        Stage: deploy

          Pipeline passed for b69720b5 on develop

          Activity

          Filter activity
          • Approvals
          • Assignees & reviewers
          • Comments (from bots)
          • Comments (from users)
          • Commits & branches
          • Edits
          • Labels
          • Lock status
          • Mentions
          • Merge request status
          • Tracking
          Please register or sign in to reply