Skip to content
Snippets Groups Projects

Refactor Actuator Farm

I split the actuator farm into two classes, one that only contains the core functionality necessary to couple it to an outside library such as WiFI and one that works on its own. The reference system has changed from the local to the global reference frame. That reduces the complexity and necessary data significantly. It also simplifies future implementations of towers or actuator disks significantly.

Because the computation changes, the Actuator Line regression test has to be updated. The quite large deviations in some points result from a bug in the old version that cut off the spreading of the forces too early.

Edited by Hkorb

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Good refactoring, the ActuatorFarm is now a lot simpler :smile:

    In addition to the comments in this review, I added two commits: some formatting and I removed unused paramters + added a missing const.

  • Anna Wellmann added 1 commit

    added 1 commit

    • f04c66e4 - Remove deleted parameter in function call

    Compare with previous version

  • Anna Wellmann approved this merge request

    approved this merge request

  • Hkorb added 1 commit

    added 1 commit

    Compare with previous version

  • Hkorb added 1 commit

    added 1 commit

    • 5b536eb0 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Hkorb added 1 commit

    added 1 commit

    • 92471b29 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Hkorb resolved all threads

    resolved all threads

  • Your regression test is failing because of this refactoring. Do you still want to merge this? If yes I would like to ask you to update the reference data.

  • Hkorb added 68 commits

    added 68 commits

    Compare with previous version

  • Author Reporter

    I rebased onto the current version of develop and I see that you beat me to updating the reference data

    Edited by Hkorb
  • Anna Wellmann mentioned in commit d7adaa22

    mentioned in commit d7adaa22

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading