Feature/cleanup vf cpu (Closed #3)
2 unresolved threads
2 unresolved threads
-
Removed and comment a lot of unused variables.
-
In D3Q27System.h removed using namespace UbMat.
-
added overrides
-
In the class ThixotropyInterpolationProcessor I renamed calcInterpolatedCoefficiets() into calcInterpolatedCoefficiets_intern(). The reason was, that this method hides the virtual function calcInterpolatedCoefficiets() from the base class.
Merge request reports
Activity
7 7 #include "LBMKernel.h" 8 8 #include "Thixotropy.h" 9 9 10 #define PROOF_CORRECTNESS 10 #define PROOF_CORRECTNES changed this line in version 2 of the diff
38 35 const int invDir = D3Q27System::INVDIR[fdir]; 39 36 LBMReal q = bcPtr->getQ(invDir);// m+m q=0 stabiler 40 37 LBMReal velocity = bcPtr->getBoundaryVelocity(invDir); 41 38 LBMReal fReturn = ((1.0-q)/(1.0+q))*((f[invDir]-feq[invDir])/(1.0-collFactor)+feq[invDir])+((q*(f[invDir]+f[fdir])-velocity*rho)/(1.0+q)); Obviously, it is a bug. It should be collFactorF instead collFactor! We need lines 29 and 30.
Edited by Konstantin Kutscherchanged this line in version 4 of the diff
added 1 commit
- 71219dbb - Bugfix: fReturn should be calculated with collFactorF.
mentioned in commit 051cc181
Please register or sign in to reply