From b714367882b11330daf24f7002180e78540e5890 Mon Sep 17 00:00:00 2001
From: Soeren Peters <peters.soeren@gmx.net>
Date: Thu, 11 Feb 2021 09:07:46 +0100
Subject: [PATCH] ADds -Wextra and -pedantic flag and removes a few warnings.
---
CMake/compilerflags/AppleClang.cmake | 5 ++++-
src/basics/basics/utilities/UbLogger.h | 2 +-
src/basics/geometry3d/GbCuboid3D.h | 2 +-
src/basics/geometry3d/GbObjectGroup3D.cpp | 2 +-
src/basics/geometry3d/GbObjectGroup3D.h | 2 +-
5 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/CMake/compilerflags/AppleClang.cmake b/CMake/compilerflags/AppleClang.cmake
index aecc48fa5..350561865 100644
--- a/CMake/compilerflags/AppleClang.cmake
+++ b/CMake/compilerflags/AppleClang.cmake
@@ -16,7 +16,10 @@ list(APPEND CAB_COMPILER_ADDTIONAL_CXX_COMPILER_FLAGS "-fPIC") # position indepe
# warnings
#############################################################################################################
list(APPEND CAB_COMPILER_ADDTIONAL_CXX_COMPILER_FLAGS "-Wall")
-list(APPEND CAB_COMPILER_ADDTIONAL_CXX_COMPILER_FLAGS "-Wunreachable-code")
+list(APPEND CAB_COMPILER_ADDTIONAL_CXX_COMPILER_FLAGS "-Wextra")
+list(APPEND CAB_COMPILER_ADDTIONAL_CXX_COMPILER_FLAGS "-pedantic")
+
+#list(APPEND CAB_COMPILER_ADDTIONAL_CXX_COMPILER_FLAGS "-Wunreachable-code")
list(APPEND CAB_COMPILER_ADDTIONAL_CXX_COMPILER_FLAGS "-Wno-unused-function")
list(APPEND CAB_COMPILER_ADDTIONAL_CXX_COMPILER_FLAGS "-Wno-reorder")
diff --git a/src/basics/basics/utilities/UbLogger.h b/src/basics/basics/utilities/UbLogger.h
index d350a7637..fc2b11871 100644
--- a/src/basics/basics/utilities/UbLogger.h
+++ b/src/basics/basics/utilities/UbLogger.h
@@ -228,7 +228,7 @@ inline std::string UbLogger<OutputPolicy>::logTimeString()
char buffer[11];
time_t t;
time(&t);
- tm r = { 0 };
+ tm r; // = { 0 };
strftime(buffer, sizeof(buffer), "%X", localtime_r(&t, &r));
struct timeval tv;
gettimeofday(&tv, 0);
diff --git a/src/basics/geometry3d/GbCuboid3D.h b/src/basics/geometry3d/GbCuboid3D.h
index f0a0b0f98..762a08c26 100644
--- a/src/basics/geometry3d/GbCuboid3D.h
+++ b/src/basics/geometry3d/GbCuboid3D.h
@@ -80,7 +80,7 @@ public:
void setCenterCoordinates(const double &x1, const double &x2, const double &x3) override;
void translate(const double &x1, const double &x2, const double &x3) override;
- void rotate(const double &rx1, const double &rx2, const double &rx3) override {}
+ void rotate(const double &rx1, const double &rx2, const double &rx3) override { (void)rx1; (void)rx2; (void)rx3; }
void scale(const double &sx1, const double &sx2, const double &sx3) override;
double getLengthX1();
diff --git a/src/basics/geometry3d/GbObjectGroup3D.cpp b/src/basics/geometry3d/GbObjectGroup3D.cpp
index e83ea5a60..4d7656918 100644
--- a/src/basics/geometry3d/GbObjectGroup3D.cpp
+++ b/src/basics/geometry3d/GbObjectGroup3D.cpp
@@ -83,7 +83,7 @@ vector<GbTriangle3D *> GbObjectGroup3D::getSurfaceTriangleSet()
return allTriangles;
}
/*=======================================================*/
-void GbObjectGroup3D::addSurfaceTriangleSet(vector<UbTupleFloat3> &nodes, vector<UbTupleInt3> &triangles) {}
+void GbObjectGroup3D::addSurfaceTriangleSet(vector<UbTupleFloat3> &/*nodes*/, vector<UbTupleInt3> &/*triangles*/) {}
/*=======================================================*/
bool GbObjectGroup3D::hasIntersectionWithDirectedLine(GbPoint3D /*origin*/, GbPoint3D /*direction*/) { return false; }
/*=======================================================*/
diff --git a/src/basics/geometry3d/GbObjectGroup3D.h b/src/basics/geometry3d/GbObjectGroup3D.h
index a94703dc1..51413cbe9 100644
--- a/src/basics/geometry3d/GbObjectGroup3D.h
+++ b/src/basics/geometry3d/GbObjectGroup3D.h
@@ -89,7 +89,7 @@ public:
this->midPoint->translate(x1, x2, x3);
this->notifyObserversObjectChanged();
}
- void rotate(const double &rx1, const double &rx2, const double &rx3) override
+ void rotate(const double &/*rx1*/, const double &/*rx2*/, const double &/*rx3*/) override
{ /* rotation makes no sense*/
}
void scale(const double &sx1, const double & /*sx2*/, const double & /*sx3*/) override { this->radius *= sx1; }
--
GitLab