From aae11620ed426ea6019d9b7313b9a8ebcac6a791 Mon Sep 17 00:00:00 2001
From: peters <peters@irmb.tu-bs.de>
Date: Tue, 29 Jun 2021 15:37:15 +0200
Subject: [PATCH] Rework uninitalized variables in cpu code
---
src/basics/geometry3d/GbTriFaceMesh3D.cpp | 11 +--
.../CoProcessors/MPIIOCoProcessor.cpp | 7 +-
.../MPIIOMigrationBECoProcessor.cpp | 34 ++++++---
.../MPIIOMigrationCoProcessor.cpp | 76 ++++++++++++++-----
.../CoProcessors/MPIIORestartCoProcessor.cpp | 72 +++++++++++++-----
.../TimeAveragedValuesCoProcessor.cpp | 2 +-
.../Parallel/MetisPartitioner.cpp | 2 +-
.../Utilities/CheckpointConverter.cpp | 15 +++-
...SetInterpolationConnectorsBlockVisitor.cpp | 2 +-
9 files changed, 160 insertions(+), 61 deletions(-)
diff --git a/src/basics/geometry3d/GbTriFaceMesh3D.cpp b/src/basics/geometry3d/GbTriFaceMesh3D.cpp
index 92442dd54..f4622a5f3 100644
--- a/src/basics/geometry3d/GbTriFaceMesh3D.cpp
+++ b/src/basics/geometry3d/GbTriFaceMesh3D.cpp
@@ -1111,17 +1111,18 @@ void GbTriFaceMesh3D::readMeshFromSTLFileBinary(string filename, bool removeRedu
UB_THROW(UbException(UB_EXARGS, "Can not open STL file: " + filename));
}
char title[80];
- int nFaces;
- fread(title, 80, 1, f);
- fread((void *)&nFaces, 4, 1, f);
+ int nFaces;
+ size_t read_values = fread(title, 80, 1, f);
+ read_values = fread((void *)&nFaces, 4, 1, f);
float v[12]; // normal=3, vertices=3*3 = 12
unsigned short uint16;
// Every Face is 50 Bytes: Normal(3*float), Vertices(9*float), 2 Bytes Spacer
for (int i = 0; i < nFaces; ++i) {
for (size_t j = 0; j < 12; ++j) {
- fread((void *)&v[j], sizeof(float), 1, f);
+ read_values = fread((void *)&v[j], sizeof(float), 1, f);
}
- fread((void *)&uint16, sizeof(unsigned short), 1, f); // spacer between successive faces
+ read_values = fread((void *)&uint16, sizeof(unsigned short), 1, f); // spacer between successive faces
+ (void)read_values;
nodes->push_back(GbTriFaceMesh3D::Vertex(v[3], v[4], v[5]));
nodes->push_back(GbTriFaceMesh3D::Vertex(v[6], v[7], v[8]));
nodes->push_back(GbTriFaceMesh3D::Vertex(v[9], v[10], v[11]));
diff --git a/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOCoProcessor.cpp b/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOCoProcessor.cpp
index a3572c8c4..481311f90 100644
--- a/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOCoProcessor.cpp
+++ b/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOCoProcessor.cpp
@@ -203,7 +203,8 @@ void MPIIOCoProcessor::writeBlocks(int step)
if (rc != MPI_SUCCESS)
throw UbException(UB_EXARGS, "couldn't open file " + filename);
- double start, finish;
+ double start {0.};
+ double finish {0.};
MPI_Offset write_offset = (MPI_Offset)(size * sizeof(int));
if (comm->isRoot()) {
@@ -240,7 +241,9 @@ void MPIIOCoProcessor::readBlocks(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: "
<< Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
diff --git a/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOMigrationBECoProcessor.cpp b/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOMigrationBECoProcessor.cpp
index f82111472..0d713212c 100644
--- a/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOMigrationBECoProcessor.cpp
+++ b/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOMigrationBECoProcessor.cpp
@@ -113,7 +113,7 @@ void MPIIOMigrationBECoProcessor::writeDataSet(int step)
}
dataSetParam dataSetParamStr1, dataSetParamStr2, dataSetParamStr3;
- int firstGlobalID;
+ int firstGlobalID {0};
std::vector<double> doubleValuesArrayF; // double-values (arrays of f's) in all blocks Fdistribution
std::vector<double> doubleValuesArrayH1; // double-values (arrays of f's) in all blocks H1distribution
// std::vector<double> doubleValuesArrayH2; // double-values (arrays of f's) in all blocks H2distribution
@@ -286,7 +286,9 @@ void MPIIOMigrationBECoProcessor::writeDataSet(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -412,7 +414,7 @@ void MPIIOMigrationBECoProcessor::write4DArray(int step, Arrays arrayType, std::
blocksCount += static_cast<int>(blocksVector[level].size());
}
- int firstGlobalID;
+ int firstGlobalID {0};
std::vector<double> doubleValuesArray; // double-values of the data array in all blocks
dataSetParam dataSetParamStr;
bool firstBlock = true;
@@ -483,7 +485,9 @@ void MPIIOMigrationBECoProcessor::write4DArray(int step, Arrays arrayType, std::
MPI_Type_contiguous(doubleCountInBlock, MPI_DOUBLE, &dataSetDoubleType);
MPI_Type_commit(&dataSetDoubleType);
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -529,7 +533,7 @@ void MPIIOMigrationBECoProcessor::write3DArray(int step, Arrays arrayType, std::
blocksCount += static_cast<int>(blocksVector[level].size());
}
- int firstGlobalID;
+ int firstGlobalID {0};
std::vector<double> doubleValuesArray; // double-values of the data array in all blocks
dataSetParam dataSetParamStr;
bool firstBlock = true;
@@ -595,7 +599,9 @@ void MPIIOMigrationBECoProcessor::write3DArray(int step, Arrays arrayType, std::
MPI_Type_contiguous(doubleCountInBlock, MPI_DOUBLE, &dataSetDoubleType);
MPI_Type_commit(&dataSetDoubleType);
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -739,7 +745,9 @@ void MPIIOMigrationBECoProcessor::writeBoundaryConds(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1018,7 +1026,9 @@ void MPIIOMigrationBECoProcessor::readDataSet(int step)
int indexB = rank * blocksPerProcess; // the first "my" block
int indexE = indexB + int(myBlocksCount); // the latest "my" block
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1261,7 +1271,9 @@ void MPIIOMigrationBECoProcessor::readArray(int step, Arrays arrType, std::strin
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1415,7 +1427,9 @@ void MPIIOMigrationBECoProcessor::readBoundaryConds(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
diff --git a/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOMigrationCoProcessor.cpp b/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOMigrationCoProcessor.cpp
index fae3b4846..87ded2580 100644
--- a/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOMigrationCoProcessor.cpp
+++ b/src/cpu/VirtualFluidsCore/CoProcessors/MPIIOMigrationCoProcessor.cpp
@@ -318,7 +318,9 @@ void MPIIOMigrationCoProcessor::writeDataSet(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -533,7 +535,9 @@ void MPIIOMigrationCoProcessor::write4DArray(int step, Arrays arrayType, std::st
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -655,7 +659,9 @@ void MPIIOMigrationCoProcessor::write3DArray(int step, Arrays arrayType, std::st
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -779,7 +785,9 @@ averageDensityArray->getDataVector().begin(), averageDensityArray->getDataVector
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_Info info = MPI_INFO_NULL;
@@ -894,7 +902,9 @@ AverageVelocityArray3DPtr->getDataVector().begin(), AverageVelocityArray3DPtr->g
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_Info info = MPI_INFO_NULL;
@@ -1009,7 +1019,9 @@ AverageFluctArray3DPtr->getDataVector().begin(), AverageFluctArray3DPtr->getData
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_Info info = MPI_INFO_NULL;
@@ -1129,7 +1141,9 @@ AverageTripleArray3DPtr->getDataVector().begin(), AverageTripleArray3DPtr->getDa
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_Info info = MPI_INFO_NULL;
@@ -1250,7 +1264,9 @@ ShearStressValArray3DPtr->getDataVector().begin(), ShearStressValArray3DPtr->get
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_Info info = MPI_INFO_NULL;
@@ -1371,7 +1387,9 @@ relaxationFactor3DPtr->getDataVector().begin(), relaxationFactor3DPtr->getDataVe
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_Info info = MPI_INFO_NULL;
@@ -1530,7 +1548,9 @@ void MPIIOMigrationCoProcessor::writeBoundaryConds(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: "<< Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1642,7 +1662,9 @@ void MPIIOMigrationCoProcessor::readDataSet(int step)
UBLOG(logINFO, "MPIIOMigrationCoProcessor::readDataSet start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1910,7 +1932,9 @@ void MPIIOMigrationCoProcessor::readArray(int step, Arrays arrType, std::string
UBLOG(logINFO, "MPIIOMigrationCoProcessor::readArray start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -2055,7 +2079,9 @@ void MPIIOMigrationCoProcessor::readArray(int step, Arrays arrType, std::string
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() /
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_File file_handler;
@@ -2161,7 +2187,9 @@ void MPIIOMigrationCoProcessor::readAverageVelocityArray(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() /
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_File file_handler;
@@ -2266,7 +2294,9 @@ void MPIIOMigrationCoProcessor::readAverageFluktuationsArray(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() /
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_File file_handler;
@@ -2371,7 +2401,9 @@ void MPIIOMigrationCoProcessor::readAverageTripleArray(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() /
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_File file_handler;
@@ -2476,7 +2508,9 @@ void MPIIOMigrationCoProcessor::readShearStressValArray(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() /
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_File file_handler;
@@ -2581,7 +2615,9 @@ void MPIIOMigrationCoProcessor::readRelaxationFactor(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() /
1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot()) start = MPI_Wtime();
MPI_File file_handler;
@@ -2685,7 +2721,9 @@ void MPIIOMigrationCoProcessor::readBoundaryConds(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
diff --git a/src/cpu/VirtualFluidsCore/CoProcessors/MPIIORestartCoProcessor.cpp b/src/cpu/VirtualFluidsCore/CoProcessors/MPIIORestartCoProcessor.cpp
index 02e471c4d..f69514478 100644
--- a/src/cpu/VirtualFluidsCore/CoProcessors/MPIIORestartCoProcessor.cpp
+++ b/src/cpu/VirtualFluidsCore/CoProcessors/MPIIORestartCoProcessor.cpp
@@ -344,7 +344,9 @@ void MPIIORestartCoProcessor::writeDataSet(int step)
}
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -547,7 +549,9 @@ void MPIIORestartCoProcessor::writeAverageDensityArray(int step)
}
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -682,7 +686,9 @@ void MPIIORestartCoProcessor::writeAverageVelocityArray(int step)
}
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -818,7 +824,9 @@ void MPIIORestartCoProcessor::writeAverageFluktuationsArray(int step)
}
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -955,7 +963,9 @@ void MPIIORestartCoProcessor::writeAverageTripleArray(int step)
}
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1092,7 +1102,9 @@ void MPIIORestartCoProcessor::writeShearStressValArray(int step)
}
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1230,7 +1242,9 @@ void MPIIORestartCoProcessor::writeRelaxationFactor(int step)
}
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1369,7 +1383,9 @@ void MPIIORestartCoProcessor::writePhaseField(int step, int fieldN)
}
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1563,7 +1579,9 @@ void MPIIORestartCoProcessor::writeBoundaryConds(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1652,7 +1670,9 @@ void MPIIORestartCoProcessor::readDataSet(int step)
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1887,7 +1907,9 @@ void MPIIORestartCoProcessor::readAverageDensityArray(int step)
UBLOG(logINFO, "MPIIORestartCoProcessor::readAverageDensityArray start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -1986,7 +2008,9 @@ void MPIIORestartCoProcessor::readAverageVelocityArray(int step)
UBLOG(logINFO, "MPIIORestartCoProcessor::readAverageVelocityArray start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -2083,7 +2107,9 @@ void MPIIORestartCoProcessor::readAverageFluktuationsArray(int step)
UBLOG(logINFO, "MPIIORestartCoProcessor::readAverageFluktuationsArray start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -2181,7 +2207,9 @@ void MPIIORestartCoProcessor::readAverageTripleArray(int step)
UBLOG(logINFO, "MPIIORestartCoProcessor::readAverageTripleArray start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -2278,7 +2306,9 @@ void MPIIORestartCoProcessor::readShearStressValArray(int step)
UBLOG(logINFO, "MPIIORestartCoProcessor::readShearStressValArray start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -2375,7 +2405,9 @@ void MPIIORestartCoProcessor::readRelaxationFactor(int step)
UBLOG(logINFO, "MPIIORestartCoProcessor::readRelaxationFactor start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -2472,7 +2504,9 @@ void MPIIORestartCoProcessor::readPhaseField(int step, int fieldN)
UBLOG(logINFO, "MPIIORestartCoProcessor::readPhaseField start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -2577,7 +2611,9 @@ void MPIIORestartCoProcessor::readBoundaryConds(int step)
UBLOG(logINFO, "MPIIORestartCoProcessor::readBoundaryConds start MPI IO rank = " << rank);
UBLOG(logINFO, "Physical Memory currently used by current process: " << Utilities::getPhysMemUsedByMe() / 1073741824.0 << " GB");
}
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
diff --git a/src/cpu/VirtualFluidsCore/CoProcessors/TimeAveragedValuesCoProcessor.cpp b/src/cpu/VirtualFluidsCore/CoProcessors/TimeAveragedValuesCoProcessor.cpp
index 27f25fbfe..24230ca99 100644
--- a/src/cpu/VirtualFluidsCore/CoProcessors/TimeAveragedValuesCoProcessor.cpp
+++ b/src/cpu/VirtualFluidsCore/CoProcessors/TimeAveragedValuesCoProcessor.cpp
@@ -384,7 +384,7 @@ void TimeAveragedValuesCoProcessor::calculateAverageValues(double timeSteps)
maxX2 -= 2;
maxX3 -= 2;
- LBMReal rho, ux, uy, uz, uxx, uzz, uyy, uxy, uxz, uyz, rhof;
+ LBMReal rho {0.}, ux {0.}, uy {0.}, uz {0.}, uxx {0.}, uzz {0.}, uyy {0.}, uxy {0.}, uxz {0.}, uyz {0.}, rhof {0.};
for (int ix3 = minX3; ix3 <= maxX3; ix3++) {
for (int ix2 = minX2; ix2 <= maxX2; ix2++) {
diff --git a/src/cpu/VirtualFluidsCore/Parallel/MetisPartitioner.cpp b/src/cpu/VirtualFluidsCore/Parallel/MetisPartitioner.cpp
index 937766684..51d74e3bf 100644
--- a/src/cpu/VirtualFluidsCore/Parallel/MetisPartitioner.cpp
+++ b/src/cpu/VirtualFluidsCore/Parallel/MetisPartitioner.cpp
@@ -24,7 +24,7 @@ void MetisPartitioner::setMetisOptions(int option, idx_t value) { options[option
//////////////////////////////////////////////////////////////////////////
int MetisPartitioner::partition(int nofParts, MetisPartitioner::PartType ptype)
{
- int rc;
+ int rc {0};
idx_t nvtxs = (idx_t)xadj.size() - 1; // number of nodes
idx_t ncon = (idx_t)vwgt.size() / nvtxs; // number Of node constraints;
part.resize(nvtxs);
diff --git a/src/cpu/VirtualFluidsCore/Utilities/CheckpointConverter.cpp b/src/cpu/VirtualFluidsCore/Utilities/CheckpointConverter.cpp
index b66eff480..146f5eccc 100644
--- a/src/cpu/VirtualFluidsCore/Utilities/CheckpointConverter.cpp
+++ b/src/cpu/VirtualFluidsCore/Utilities/CheckpointConverter.cpp
@@ -133,7 +133,9 @@ void CheckpointConverter::convert(int step, int procCount)
void CheckpointConverter::convertBlocks(int step, int procCount)
{
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
start = MPI_Wtime();
// file to read from
@@ -295,7 +297,9 @@ void CheckpointConverter::convertDataSet(int step, int procCount)
if (rcW != MPI_SUCCESS)
throw UbException(UB_EXARGS, "couldn't open file " + filenameW);
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
start = MPI_Wtime();
int blocksCount = 0;
@@ -429,7 +433,9 @@ void CheckpointConverter::convertDataSet(int step, int procCount)
void CheckpointConverter::convert___Array(int /*step*/, int procCount, std::string filenameR, std::string filenameW)
{
- double start, finish;
+
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
@@ -523,7 +529,8 @@ void CheckpointConverter::convertBC(int step, int procCount)
if (rcW != MPI_SUCCESS)
throw UbException(UB_EXARGS, "couldn't open file " + filenameW);
- double start, finish;
+ double start {0.};
+ double finish {0.};
if (comm->isRoot())
start = MPI_Wtime();
diff --git a/src/cpu/VirtualFluidsCore/Visitors/SetInterpolationConnectorsBlockVisitor.cpp b/src/cpu/VirtualFluidsCore/Visitors/SetInterpolationConnectorsBlockVisitor.cpp
index 8a83a0c6d..8c0d4b930 100644
--- a/src/cpu/VirtualFluidsCore/Visitors/SetInterpolationConnectorsBlockVisitor.cpp
+++ b/src/cpu/VirtualFluidsCore/Visitors/SetInterpolationConnectorsBlockVisitor.cpp
@@ -343,7 +343,7 @@ void SetInterpolationConnectorsBlockVisitor::setInterpolationConnectors(SPtr<Blo
if(fBlockNE) fBlockNERank = fBlockNE->getRank();
int cBlockRank = cBlock->getRank();
- LBMReal omegaF;
+ LBMReal omegaF {0.0};
if(fBlockSW) omegaF =LBMSystem::calcCollisionFactor(nue, fBlockSW->getLevel());
if(fBlockNW) omegaF =LBMSystem::calcCollisionFactor(nue, fBlockNW->getLevel());
if(fBlockSE) omegaF =LBMSystem::calcCollisionFactor(nue, fBlockSE->getLevel());
--
GitLab