From 815ae0c719daef96a1d0a4bb09b14ec9fed3b229 Mon Sep 17 00:00:00 2001
From: Anna Wellmann <a.wellmann@tu-braunschweig.de>
Date: Tue, 25 Apr 2023 16:53:58 +0200
Subject: [PATCH] Remove superfluous virtuals
---
.../Factories/BoundaryConditionFactory.h | 11 ++++++-----
.../VirtualFluids_GPU/KernelManager/BCKernelManager.h | 2 +-
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/gpu/VirtualFluids_GPU/Factories/BoundaryConditionFactory.h b/src/gpu/VirtualFluids_GPU/Factories/BoundaryConditionFactory.h
index 31ecc91f0..09f1a4416 100644
--- a/src/gpu/VirtualFluids_GPU/Factories/BoundaryConditionFactory.h
+++ b/src/gpu/VirtualFluids_GPU/Factories/BoundaryConditionFactory.h
@@ -162,11 +162,12 @@ public:
// https://git.rz.tu-bs.de/m.schoenherr/VirtualFluids_dev/-/issues/16
[[nodiscard]] virtual boundaryCondition getVelocityBoundaryConditionPost(bool isGeometryBC = false) const;
- [[nodiscard]] virtual boundaryCondition getNoSlipBoundaryConditionPost(bool isGeometryBC = false) const;
- [[nodiscard]] virtual boundaryCondition getSlipBoundaryConditionPost(bool isGeometryBC = false) const;
- [[nodiscard]] virtual boundaryCondition getPressureBoundaryConditionPre() const;
- [[nodiscard]] virtual boundaryCondition getGeometryBoundaryConditionPost() const;
- [[nodiscard]] virtual boundaryConditionWithParameter getStressBoundaryConditionPost() const;
+ [[nodiscard]] boundaryCondition getNoSlipBoundaryConditionPost(bool isGeometryBC = false) const;
+ [[nodiscard]] boundaryCondition getSlipBoundaryConditionPost(bool isGeometryBC = false) const;
+ [[nodiscard]] boundaryCondition getPressureBoundaryConditionPre() const;
+ [[nodiscard]] boundaryCondition getGeometryBoundaryConditionPost() const;
+
+ [[nodiscard]] boundaryConditionWithParameter getStressBoundaryConditionPost() const;
[[nodiscard]] precursorBoundaryConditionFunc getPrecursorBoundaryConditionPost() const;
private:
diff --git a/src/gpu/VirtualFluids_GPU/KernelManager/BCKernelManager.h b/src/gpu/VirtualFluids_GPU/KernelManager/BCKernelManager.h
index fa97e9483..339100e6b 100644
--- a/src/gpu/VirtualFluids_GPU/KernelManager/BCKernelManager.h
+++ b/src/gpu/VirtualFluids_GPU/KernelManager/BCKernelManager.h
@@ -113,10 +113,10 @@ private:
SPtr<Parameter> para;
- boundaryCondition pressureBoundaryConditionPre = nullptr;
boundaryCondition velocityBoundaryConditionPost = nullptr;
boundaryCondition noSlipBoundaryConditionPost = nullptr;
boundaryCondition slipBoundaryConditionPost = nullptr;
+ boundaryCondition pressureBoundaryConditionPre = nullptr;
boundaryCondition geometryBoundaryConditionPost = nullptr;
boundaryConditionWithParameter stressBoundaryConditionPost = nullptr;
precursorBoundaryCondition precursorBoundaryConditionPost = nullptr;
--
GitLab